Fixes User Defined Toolchain clang type forgetfulness#1179
Merged
Conversation
jonahgraham
approved these changes
Jun 5, 2025
jonahgraham
left a comment
jonahgraham
left a comment
Member
There was a problem hiding this comment.
@betamaxbandit LGTM - this can be merged once #1185 is ready
jonahgraham
added
the
build
Member
|
@betamaxbandit can you rebase and merge once it passes CI? |
betamaxbandit
force-pushed
the
clangType
branch
from
143bbe7 to
ceb4d86
Compare
When a User Defined Toolchain of type clang was created (Preferences > C/C++ > Core Build Toolchains > User Defined Toolchains) the Type was reported correctly as clang. But after restarting the workbench the Type was reported as GCC. This is now fixed so the Type always shows as clang for a clang toolchain.
betamaxbandit
force-pushed
the
clangType
branch
from
ceb4d86 to
6a20cf9
Compare
Contributor
Author
|
Manual Test:
|
Contributor
Author
|
I have rebased this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a User Defined Toolchain of type clang was created (Preferences > C/C++ > Core Build Toolchains > User Defined Toolchains) the Type was reported correctly as clang. But after restarting the workbench the Type was reported as GCC. This is now fixed so the Type always shows as clang for a clang toolchain.